[SERVER-39024] PCQ::popMany should return a container, rather than output to an iterator Created: 15/Jan/19  Updated: 29/Oct/23  Resolved: 30/Jan/19

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.1.8

Type: Improvement Priority: Major - P3
Reporter: Mira Carey Assignee: Mira Carey
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2019-01-28, Service Arch 2019-02-11
Participants:

 Description   

Writing to an output iterator is wonky, and dangerous when it comes to raw pointers. Rather than relying on that, let's return our internal container directly and allow for stealing the queue if we're taking all the elements.



 Comments   
Comment by Githook User [ 30/Jan/19 ]

Author:

{'username': 'hanumantmk', 'email': 'jcarey@argv.me', 'name': 'Jason Carey'}

Message: SERVER-39024 Improve PCQ::popMany

improve the ProduceConsumerQueue's popMany and popManyUpTo to return a
deque, rather than writing to an output iterator.
Branch: master
https://github.com/mongodb/mongo/commit/3a9efc840255c252732429b97c8b36ded52ed417

Generated at Thu Feb 08 04:50:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.