[SERVER-3906] the values of nodes in Already class is never updated Created: 20/Sep/11  Updated: 11/Jul/16  Resolved: 22/Sep/11

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 2.1.0

Type: Bug Priority: Minor - P4
Reporter: Guanqun Lu Assignee: Dwight Merriman
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

2.6.40.4-5.fc15.i686.debug #1 SMP Tue Aug 30 14:29:53 UTC 2011 i686 i686 i386 GNU/Linux


Operating System: ALL
Participants:

 Description   

In the original code, one node is retrieved by value, therefore, the corresponding value is never changed in following code, we should use "reference" instead in order to get what we expect.



 Comments   
Comment by auto [ 22/Sep/11 ]

Author:

{u'login': u'erh', u'name': u'Eliot', u'email': u'eliot@10gen.com'}

Message: Merge pull request #89 from guanqun/FIX-SERVER-3906

fix checkAndSet in Already class
Branch: master
https://github.com/mongodb/mongo/commit/81b4dd424400a662c944c001acce7a619100cbc8

Comment by Dwight Merriman [ 21/Sep/11 ]

will do

Comment by Guanqun Lu [ 21/Sep/11 ]

Could you guys please take a quick look at my fix whether it's sensible or not?

Thanks!

Comment by Guanqun Lu [ 20/Sep/11 ]

I've done a simple fix:

Here's the pull request:
https://github.com/mongodb/mongo/pull/89

Here's the commit:
https://github.com/guanqun/mongo/commit/11a2a5ea385539dcae09c030199bbb118b7be20c

Please kindly review this patch.

Thanks!

Generated at Thu Feb 08 03:04:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.