[SERVER-39115] GlobalLock can return without throwing when instructed to throw Created: 22/Jan/19 Updated: 20/Feb/19 Resolved: 20/Feb/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Xiangyu Yao (Inactive) |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Storage NYC 2019-02-11, Storage NYC 2019-02-25 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 69 | ||||||||||||
| Description |
|
We can early return here when we should be throwing like here |
| Comments |
| Comment by Xiangyu Yao (Inactive) [ 20/Feb/19 ] |
|
Closing this ticket as the problem described has been fixed in |
| Comment by Judah Schvimer [ 04/Feb/19 ] |
|
Assigning this to the Storage NYC Team because the GlobalLock constructor interface is confusing and we are not confident in the desired solution. The kThrow argument sounds like a contract that the constructor will throw if lock acquisition fails, but rather it means that we will not choose to explicitly swallow exceptions. We do not think this ticket represents a bug. |
| Comment by Tess Avitabile (Inactive) [ 22/Jan/19 ] |
|
It's possible that this is not a problem if we always throw here when the InterruptBehavior is kThrow. |