[SERVER-39141] The range deleter should retry on write conflict exceptions Created: 22/Jan/19 Updated: 29/Oct/23 Resolved: 10/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.2.0-rc3, 4.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jack Mulrow | Assignee: | Alexander Taskov (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | open_todo_in_code, todo_in_code | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Backport Requested: |
v4.2
|
||||||||||||||||
| Sprint: | Sharding 2019-02-25, Sharding 2019-06-03, Sharding 2019-06-17 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The range deleter deletes orphan documents by constructing a PlanExecutor with a YIELD_MANUAL yield policy. Because of this, any write conflict errors encountered will be re-thrown, but there is no WriteConflictRetry loop in CollectionRangeDeleter::cleanUpNextRange, causing post-migration orphan cleanup and cleanupOrphaned commands to fail unnecessarily. The net effect of this is that more orphans remain on the system. |
| Comments |
| Comment by Githook User [ 13/Feb/20 ] |
|
Author: {'username': 'alextaskov', 'name': 'Alex Taskov', 'email': 'alex.taskov@mongodb.com'}Message: |
| Comment by Githook User [ 10/Jun/19 ] |
|
Author: {'name': 'Alex Taskov', 'email': 'alex.taskov@mongodb.com', 'username': 'alextaskov'}Message: (cherry picked from commit ece39c7650b76a45ee2357dc4a7adb2ab195eda4) |
| Comment by Githook User [ 10/Jun/19 ] |
|
Author: {'name': 'Alex Taskov', 'email': 'alex.taskov@mongodb.com', 'username': 'alextaskov'}Message: |
| Comment by Kaloian Manassiev [ 04/Feb/19 ] |
|
Ah, that makes sense, thanks Jack! I removed the 3.6 and 4.0 links. |
| Comment by Jack Mulrow [ 04/Feb/19 ] |
|
kaloian.manassiev, I'm not sure this affects 4.0 and 3.6. On both of those branches it looks like the deletes are in a WriteConflictRetryLoop: 4.0 and 3.6.
|