[SERVER-39149] Homogenize getmore fail points and cursor lifetime Created: 23/Jan/19  Updated: 29/Oct/23  Resolved: 08/Feb/19

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.1.8

Type: Improvement Priority: Major - P3
Reporter: Mira Carey Assignee: Mira Carey
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2019-01-28, Service Arch 2019-02-11, Service Arch 2019-02-25
Participants:
Linked BF Score: 29

 Description   

Cursor's have subtly different semantics across mongos and mongod and between legacy getMore and command getMore. (as does the find command)

Ensuring that all getMores can be paused by waitAfterPinningCursorBeforeGetMoreBatch, and that cursors are cleaned up if they are killed after verifying auth, makes testing a bit simpler and cursors less leaky

And adding a check for waitInFindBeforeMakingBatch to runQuery similarly makes it easier to test



 Comments   
Comment by Githook User [ 08/Feb/19 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-39149 Homogenize getMore behavior

Cursor's have subtly different semantics across mongos and mongod and
between legacy getMore and command getMore. (as does the find command)

Ensuring that all getMores can be paused by
waitAfterPinningCursorBeforeGetMoreBatch, and that cursors are cleaned
up if they are killed after verifying auth, makes testing a bit simpler
and cursors less leaky

And adding a check for waitInFindBeforeMakingBatch to runQuery similarly
makes it easier to test
Branch: master
https://github.com/mongodb/mongo/commit/423c52989aa0e623618a52cab2e1c451b00658d9

Comment by Githook User [ 08/Feb/19 ]

Author:

{'name': 'James Wahlin', 'email': 'james@mongodb.com', 'username': 'jameswahlin'}

Message: Revert "SERVER-39149 Homogenize getMore behavior"

This reverts commit 4d703e26c2801971d538f948a4dc3191994f0074.
Branch: master
https://github.com/mongodb/mongo/commit/87ea6539360b6003aa75a1f40c0e294a8ae4a359

Comment by Githook User [ 07/Feb/19 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-39149 Homogenize getMore behavior

Cursor's have subtly different semantics across mongos and mongod and
between legacy getMore and command getMore. (as does the find command)

Ensuring that all getMores can be paused by
waitAfterPinningCursorBeforeGetMoreBatch, and that cursors are cleaned
up if they are killed after verifying auth, makes testing a bit simpler
and cursors less leaky

And adding a check for waitInFindBeforeMakingBatch to runQuery similarly
makes it easier to test
Branch: master
https://github.com/mongodb/mongo/commit/4d703e26c2801971d538f948a4dc3191994f0074

Generated at Thu Feb 08 04:51:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.