[SERVER-39173] Remove unnecessary sleep when MongoRunner kills mongod node with SIGKILL Created: 24/Jan/19 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Shell |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | William Schultz (Inactive) | Assignee: | Backlog - Replication Team |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Assigned Teams: |
Replication
|
||||
| Participants: | |||||
| Description |
|
When MongoRunner shuts down a node with a SIGKILL signal it sleeps for 4 seconds before completing the shutdown. This sleep makes forceful shutdowns arbitrarily slow and can slow down JS tests that kill nodes. We should remove this sleep if it has no adverse impacts. |
| Comments |
| Comment by William Schultz (Inactive) [ 11/Feb/19 ] |
|
As one concrete example of a gain to be had, a sample rollback fuzzer test (rollback_test-e04b-1548728095820-0.js |
| Comment by Sara Williamson [ 28/Jan/19 ] |
|
william.schultz Please feel free to do any investigation to confirm whether or not this possible, and include the Platforms team in the code review. -acm |
| Comment by Eric Milkie [ 24/Jan/19 ] |
|
The sleep might only be necessary on Windows. If no test suites fail on Windows after this change, it should be safe to remove the sleep. |
| Comment by William Schultz (Inactive) [ 24/Jan/19 ] |
|
Patch build with the sleep removed: https://evergreen.mongodb.com/version/5c49dc3be3c3316169573ad4 |
| Comment by William Schultz (Inactive) [ 24/Jan/19 ] |
|
This change goes back a while, so it's tough to say why it was added in the first place. It's very possible it isn't necessary. |