[SERVER-39208] ignore InterruptedAtShutdown in ARS dtor Created: 25/Jan/19  Updated: 29/Oct/23  Resolved: 08/Feb/19

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.1.8

Type: Bug Priority: Major - P3
Reporter: Misha Tyulenev Assignee: Mira Carey
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
is related to SERVER-39427 Modify interrupt semantics for opCtx Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2019-02-11, Service Arch 2019-02-25
Participants:
Linked BF Score: 50

 Description   

LogicalSessionCacheRefresh thread does not catch InterruptedAtShutdown exception,
As the related BF stack shows up it causes the terminate to be executed.



 Comments   
Comment by Githook User [ 08/Feb/19 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-39208 ignore InterruptedAtShutdown in ARS dtor

opCtx->runWithoutInterruption can throw InterruptedAtShutdown from
opCtx->checkForInterrupt during system shutdown. As long as we use
that, we should catch and ignore failure to cleanup in that case.
Branch: master
https://github.com/mongodb/mongo/commit/5571bce8ae9a16e471140bc73f4faf7d0b5cc666

Comment by Mira Carey [ 07/Feb/19 ]

I think there's a more advanced solution in SERVER-39427, but for now we should fix the existing build failures we have in the ARS by eating InterruptedAtShutdown.

We can find something more durable a bit further down the road

Comment by Misha Tyulenev [ 05/Feb/19 ]

Passing to the Server Arch to get an opinion if the CR change is just masking the real bug: see the discussion in the https://mongodbcr.appspot.com/232540002/ .
https://github.com/mongodb/mongo/blob/master/src/mongo/s/async_requests_sender.cpp#L104 is already in try.. catch block so its not clear where the exception in the d-tor may appear.

Generated at Thu Feb 08 04:51:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.