[SERVER-39260] Uncomment test at the bottom of jstests/core/txns/timestamped_reads_wait_for_prepare_oplog_visibility.js Created: 29/Jan/19  Updated: 29/Oct/23  Resolved: 02/Apr/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.1.10

Type: Task Priority: Major - P3
Reporter: Judah Schvimer Assignee: Louis Williams
Resolution: Fixed Votes: 0
Labels: prepare_testing, txn_storage
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-42547 Complete TODO listed in SERVER-35821 Closed
Related
related to SERVER-40935 Start new transactions for each snaps... Closed
is related to SERVER-35821 readConcern:snapshot transactions nee... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-02-11, Storage NYC 2019-03-25, Storage NYC 2019-04-08
Participants:

 Description   

There is a dangling TODO for SERVER-35821



 Comments   
Comment by Judah Schvimer [ 01/May/19 ]

After SERVER-35821, snapshot reads started reading at the majority-committed timestamp

louis.williams's comment should have said "all-committed" instead of "majority-committed". I've filed SERVER-40935 to make the test test the behavior we expect.

Comment by Githook User [ 02/Apr/19 ]

Author:

{'email': 'louis.williams@mongodb.com', 'name': 'Louis Williams', 'username': 'louiswilliams'}

Message: SERVER-39260 Uncomment test at the bottom of jstests/core/txns/timestamped_reads_wait_for_prepare_oplog_visibility.js
Branch: master
https://github.com/mongodb/mongo/commit/5661c7cb174ccd776c994141f30f625a976aa444

Comment by Judah Schvimer [ 22/Mar/19 ]

louis.williams, that seems reasonable. Thank you for looking into it!

Comment by Louis Williams [ 22/Mar/19 ]

At the time it was written, readConcern: "snapshot" reads could have acquired a read timestamp that was past the all-committed timestamp. This would have been problematic. After SERVER-35821, snapshot reads started reading at the majority-committed timestamp, so it is no longer possible for snapshot reads to read at a timestamp that requires waiting for oplog visibility.

I think we should correct the test so that it resembles the current snapshot read behavior.

Generated at Thu Feb 08 04:51:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.