[SERVER-39362] Make parallel/basic.js test respect resmoke.py tag-based exclusions Created: 04/Feb/19 Updated: 27/Oct/23 Resolved: 25/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Max Hirschhorn | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Gone away | Votes: | 10 |
| Labels: | tig-qwin-eligible, tig-resmoke | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 70 | ||||||||||||||||||||||||
| Story Points: | 4 | ||||||||||||||||||||||||
| Description |
|
The jstests/parallel/basic*.js tests have a couple shortcomings due to how they are a JavaScript test that runs other JavaScript tests:
This ticket is only intended to address #1. Addressing #2a is difficult due to the existing logkeeper schema because it makes an assumption that a test has ended as soon as another test that's part of the same build_id has started. Addressing #2b is difficult because creating a new test_id is tied in resmoke.py to starting a test. A new parallel_js_test test kind should be introduced that makes use of resmoke.py's buildscripts/resmokelib/selector.py module within the ParallelJSTestCase class to filter out tests from the jstests/core/ directory that shouldn't be run by the jstests/parallel/basic*.js tests. ParallelJSTestCase._make_process() should spawn a mongo shell process with a new TestData.testSchedule array option (or similar name) where each element corresponds to the list of tests for a ScopedThread spawned by the jstests/parallel/basic*.js tests to run.
All of the logic of the ParallelTester.createJstestsLists() function should be expressed in the resmoke.py YAML suite file and performed by the ParallelJSTestCase class. In particular,
A few other notes:
|
| Comments |
| Comment by Dan Larkin-York [ 25/Aug/23 ] |
|
The parallel/basic* tests were removed by |
| Comment by Connie Chen [ 03/Apr/23 ] |
|
This will go away once |
| Comment by Max Hirschhorn [ 09/Jan/23 ] |
This is that ticket. |
| Comment by Charlie Swanson [ 09/Jan/23 ] |
|
Is this ticket thought to be the "rewrite parallel suite to be run by resmoke.py" ticket? Or is there some other ticket tracking that? |
| Comment by James Wahlin [ 27/Feb/19 ] |
|
+1 for this feature. It is surprising that tags are not respected by the parallel suites and non-intuitive that a separate blacklist exists and requires updating. |