[SERVER-39380] Backport fix for config --force into our vendored SCons 3.0.4 Created: 05/Feb/19  Updated: 29/Oct/23  Resolved: 27/Feb/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.1.9

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Tools 2019-02-11, Dev Tools 2019-02-25, Dev Tools 2019-03-11
Participants:

 Description   

We want to cherry-pick https://github.com/SCons/scons/commit/533bef13e179053fe56a1e5e504aa080f353ed3d into our vendored scons to fix a bug on builds with --config=force.



 Comments   
Comment by Andrew Morrow (Inactive) [ 27/Feb/19 ]

As a nice side effect, doing to --config=force builds in a row no longer results in spurious recompiles on the second build.

Comment by Githook User [ 27/Feb/19 ]

Author:

{'name': 'William Deegan', 'username': 'bdbaddog', 'email': 'bill@baddogconsulting.com'}

Message: SERVER-39380 Update vendored scons to fix --config=force behavior

When SCons is run --config=force it overwrites the Decider for the
environment passed in to a decider which will rebuild everything. This
occurs even if you do no retrieve configures environment via
env=Conf.Finish(). Now when --config=force the configure logic will
clone the provided Environment, change that environment's decider, and
if you retrieve the environment via Conf.Finish() the logic will reset
the decider to the one set in the env passed to Configure().

This is a cherry-pick of the commits for
https://github.com/SCons/scons/issues/3303 into the MongoDB vendored
SCons tree.

Closes #1295

Signed-off-by: Andrew Morrow <acm@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/2ecd83f822b242db1c13f2abc3ff3593ba622149

Generated at Thu Feb 08 04:51:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.