[SERVER-39561] Split OpObserver::onTransactionCommit() into two functions for unprepared and prepared transactions respectively Created: 13/Feb/19 Updated: 29/Oct/23 Resolved: 20/Feb/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.9 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Siyuan Zhou | Assignee: | Blake Oler |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 2019-02-25 |
| Participants: |
| Description |
|
As schwerin found, the onCommit OpObserver function for prepared transaction should be marked as noexcept, but the one for unprepared transaction is allowed to throw. Separating them makes the code clearer. |
| Comments |
| Comment by Githook User [ 20/Feb/19 ] |
|
Author: {'name': 'Blake Oler', 'username': 'BlakeIsBlake', 'email': 'blake.oler@mongodb.com'}Message: |
| Comment by Judah Schvimer [ 13/Feb/19 ] |
|
blake.oler, are you doing this as part of active work we discussed? |