[SERVER-39950] Merge two oplog batching code paths Created: 04/Mar/19  Updated: 29/Oct/23  Resolved: 07/Apr/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.1.10

Type: Task Priority: Major - P3
Reporter: Siyuan Zhou Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-39434 Apply the new "commit" oplog entry fo... Closed
is related to SERVER-35130 view_catalog_cycle_lookup.js failed i... Closed
is related to SERVER-32332 Put SyncTail behind new Applier inter... Closed
is related to SERVER-36498 Remove 'config.transactions' entries ... Closed
is related to SERVER-40049 Make OplogBuffer use ProducerConsumer... Closed
Backwards Compatibility: Fully Compatible
Sprint: Storage NYC 2019-04-08
Participants:

 Description   

Initial sync uses OplogApplier::getNextApplierBatch() to for oplog batching, however secondary's batching behavior is in SyncTail::tryPopAndWaitForMore(). We should merge them into one implementation.



 Comments   
Comment by Githook User [ 07/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-39950 remove SyncTail::tryPopAndWaitForMore() and _consume()
Branch: master
https://github.com/mongodb/mongo/commit/62c32c9c68ad65157f8fdb46d34bec120a17bbf8

Comment by Githook User [ 06/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-39950 SyncTail::OpQueueBatcher::run() obtains next batch of ops using OplogApplier
Branch: master
https://github.com/mongodb/mongo/commit/3e504b77e351c266b8324abbbe4c285e4df8db77

Comment by Githook User [ 06/Apr/19 ]

Author:

{'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}

Message: SERVER-39950 make OplogApplier::getNextApplierBatch() shutdown-aware
Branch: master
https://github.com/mongodb/mongo/commit/b66c0d34088dae2a01a42c936396fc7a8f750201

Comment by Githook User [ 06/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-39950 SyncTail::oplogApplication() accepts OplogApplier::GetNextApplierBatchFn
Branch: master
https://github.com/mongodb/mongo/commit/652d22504d2990b2322aefc272b489e731edd789

Comment by Githook User [ 06/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-39950 OplogApplier::getNextApplierBatch() handles BatchLimit::slaveDelayLatestTimestamp
Branch: master
https://github.com/mongodb/mongo/commit/f48325efba7da7ac93c68dafe8e2f7704a683e1a

Comment by Siyuan Zhou [ 15/Mar/19 ]

This work will coverĀ SERVER-40169. This will also avoid duplicated work forĀ SERVER-39436 (Keep batch size accurate for oplog application) and add test coverage for batching of steady state replication.

Generated at Thu Feb 08 04:53:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.