[SERVER-39965] Make OutOfLineExecutor return a Status from schedule() Created: 05/Mar/19  Updated: 29/Oct/23  Resolved: 15/Apr/19

Status: Closed
Project: Core Server
Component/s: Concurrency
Affects Version/s: None
Fix Version/s: 4.1.11

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-40297 AsyncWorkScheduler's join method does... Closed
is depended on by SERVER-39814 Add OutOfLineExecutor to ConnectionPool Closed
Related
related to SERVER-40499 ReplicationCoordinatorImpl::_handleHe... Closed
related to SERVER-40633 Audit all uses of _replExecutor and c... Closed
related to SERVER-48264 ShardServerCatalogCacheLoader doesn't... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2019-03-11, Service Arch 2019-03-25, Service Arch 2019-04-08, Service Arch 2019-04-22
Participants:
Linked BF Score: 61

 Description   

It turns out this is necessary for ThreadPool to be an OoLE



 Comments   
Comment by Githook User [ 05/Apr/19 ]

Author:

{'email': 'ben.caimano@10gen.com', 'name': 'Ben Caimano'}

Message: SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)
Branch: master
https://github.com/mongodb/mongo/commit/a08bac3e29cd9ec3d030623894928e80c2f572dd

Comment by Githook User [ 05/Apr/19 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/60d6ceb971eb7d2c80b6d6996543dcc641fd2de9

Comment by Benjamin Caimano (Inactive) [ 03/Apr/19 ]

The failure benety.goh noticed was a known problem that I believe is fixed with SERVER-40297. I'm gonna hold off on landing this again until it lands. To let everybody know, I'd have to spam a bunch of channels, too many stakeholders in transactions to red a test.

Comment by Benety Goh [ 03/Apr/19 ]

Reopening due to unit test failures in CI system

Comment by Githook User [ 03/Apr/19 ]

Author:

{'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}

Message: Revert "SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)"

This reverts commit 04ea1d46eb6c4c78e19409f120ae2e61f2a35204.
Branch: master
https://github.com/mongodb/mongo/commit/6c2bd4b1be257ba7b9335e40c2af18ff25b7fcdd

Comment by Githook User [ 03/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: Revert "SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)"

This reverts commit c2bb78a2740f979b0ed8f11480cca6641b4a0a76.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/a07f816fb4f16d8ee0bcbac12c80a3364b9f3649

Comment by Githook User [ 02/Apr/19 ]

Author:

{'email': 'ben.caimano@10gen.com', 'name': 'Ben Caimano'}

Message: SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)
Branch: master
https://github.com/mongodb/mongo/commit/04ea1d46eb6c4c78e19409f120ae2e61f2a35204

Comment by Githook User [ 02/Apr/19 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-39965 OutOfLineExecutor Tasks are now unique_function(Status)
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c2bb78a2740f979b0ed8f11480cca6641b4a0a76

Generated at Thu Feb 08 04:53:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.