[SERVER-40005] [FLE] Implement translation for findAndModify command Created: 06/Mar/19  Updated: 29/Oct/23  Resolved: 26/Apr/19

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.1.10

Type: Task Priority: Major - P3
Reporter: Nicholas Zolnierz Assignee: Pawel Terlecki
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Query 2019-04-08, Query 2019-04-22, Query 2019-05-06
Participants:
Case:

 Description   

Encrypted fields may be present in the query and/or update portions of the command. This ticket should also handle upserts/updates to encrypted fields which are autogenerated by mongod (SERVER-39855).



 Comments   
Comment by Githook User [ 14/May/19 ]

Author:

{'name': 'Pawel Terlecki', 'username': 'pterlecki', 'email': 'pawel.terlecki@mongodb.com'}

Message: SERVER-40005 Fix FindAndModifeRequest::bypassDocumentValidation/writeConcern

Handle bypassDocumentValidation and writeConcern inside the request
like in other writeops.
Branch: master
https://github.com/mongodb/mongo/commit/ba8a1d5c3f912de150234e7513dedd2b083444ed

Comment by Githook User [ 26/Apr/19 ]

Author:

{'email': 'pawel.terlecki@mongodb.com', 'name': 'Pawel Terlecki', 'username': 'pterlecki'}

Message: SERVER-40005 Add translation for FindAndModify for FLE

Besides adding the logic for FindAndModify, the code for updates
got refactored. Test suite created based on fle_update.js. We may
consider combining those suites one day.
fle_echo.js got modified to send commands that will be
marked for translation.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/867dccdda57f8035e702f1e6a5d16f487e506ef1

Comment by Githook User [ 26/Apr/19 ]

Author:

{'name': 'Pawel Terlecki', 'username': 'pterlecki', 'email': 'pawel.terlecki@mongodb.com'}

Message: SERVER-40005 Add translation for FindAndModify for FLE

Extended FindAndModifyRequest to validate all fields in parsing and
serialize to BSON with passthru fields.
Branch: master
https://github.com/mongodb/mongo/commit/40baef6600a83443b2ae324c97928b000ca09778

Comment by Githook User [ 26/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: Revert "SERVER-40005 Add translation for FindAndModify for FLE"

This reverts commit 9318790212dead660f8f057f18ed48fba9232b83.
Branch: master
https://github.com/mongodb/mongo/commit/fe5ef2303f53773cabd01e0ce7e7cc83965fe211

Comment by Githook User [ 26/Apr/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: Revert "SERVER-40005 Add translation for FindAndModify for FLE"

This reverts commit ff404934107e83e0900f3a801e2f1cf8ce127e0e.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/75b7c310a7a82e9fa5efb53586db2147f3767fc3

Comment by Githook User [ 26/Apr/19 ]

Author:

{'name': 'Pawel Terlecki', 'username': 'pterlecki', 'email': 'pawel.terlecki@mongodb.com'}

Message: SERVER-40005 Add translation for FindAndModify for FLE

Besides adding the logic for FindAndModify, the code for updates
got refactored. Test suite created based on fle_update.js. We may
consider combining those suites one day.
fle_echo.js got modified to send commands that will be marked for
translation.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/ff404934107e83e0900f3a801e2f1cf8ce127e0e

Comment by Githook User [ 26/Apr/19 ]

Author:

{'email': 'pawel.terlecki@mongodb.com', 'name': 'Pawel Terlecki', 'username': 'pterlecki'}

Message: SERVER-40005 Add translation for FindAndModify for FLE

Extended FindAndModifyRequest to validate all fields in parsing and
serialize to BSON with passthru fields.
Branch: master
https://github.com/mongodb/mongo/commit/9318790212dead660f8f057f18ed48fba9232b83

Comment by Githook User [ 05/Apr/19 ]

Author:

{'name': 'Pawel Terlecki', 'username': 'pterlecki', 'email': 'pawel.terlecki@mongodb.com'}

Message: SERVER-40005 Added setters for query and update to FindAndModifyRequest

This is necessary for a corresponding change in enterprise modules.
Note that recreating a request member by member just for FLE would
lead to defects when somebody adds new members at some point.
Branch: master
https://github.com/mongodb/mongo/commit/0b4f23cf6567c05023e43d46729c6aa8712d7003

Comment by Nicholas Zolnierz [ 19/Mar/19 ]

See SERVER-39873 for description of autogenerated fields which should be rejected.

Generated at Thu Feb 08 04:53:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.