[SERVER-40047] Test for blocking queue should not test for non-guaranteed condition Created: 08/Mar/19  Updated: 29/Oct/23  Resolved: 19/Mar/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.1.10, 4.0.16, 3.6.18

Type: Bug Priority: Major - P3
Reporter: Matthew Russotto Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-40049 Make OplogBuffer use ProducerConsumer... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0, v3.6
Sprint: Repl 2019-03-25
Participants:
Linked BF Score: 28

 Description   

There is a test for the utility class BlockingQueue in mongodb/src/mongo/dbtests/basictests.cpp which tests to make sure a pop on an empty queue doesn't take too long. However, the class provides no such guarantee; under load, the pop may take an arbitrary amount of time. We should remove that check.

(this is on replication because the only user of this class is the OplogBufferBlockingQueue)



 Comments   
Comment by Githook User [ 28/Jan/20 ]

Author:

{'email': 'matthew.russotto@10gen.com', 'name': 'Matthew Russotto', 'username': 'mtrussotto'}

Message: SERVER-40047 Test for blocking queue should not test for non-guaranteed condition.

(cherry picked from commit c0654eacb16ed1ff98d3d7bbf8a9a949a291a9d1)
Branch: v3.6
https://github.com/mongodb/mongo/commit/c8868f90d0268db3bd597b334c3651979f458780

Comment by Githook User [ 27/Jan/20 ]

Author:

{'username': 'mtrussotto', 'name': 'Matthew Russotto', 'email': 'matthew.russotto@10gen.com'}

Message: SERVER-40047 Test for blocking queue should not test for non-guaranteed condition.

(cherry picked from commit c0654eacb16ed1ff98d3d7bbf8a9a949a291a9d1)
Branch: v4.0
https://github.com/mongodb/mongo/commit/5011c54d30b48548b3a9d3c6259547aff6535800

Comment by Githook User [ 08/Mar/19 ]

Author:

{'name': 'Matthew Russotto', 'email': 'matthew.russotto@10gen.com', 'username': 'mtrussotto'}

Message: SERVER-40047 Test for blocking queue should not test for non-guaranteed condition.
Branch: master
https://github.com/mongodb/mongo/commit/c0654eacb16ed1ff98d3d7bbf8a9a949a291a9d1

Comment by Matthew Russotto [ 08/Mar/19 ]

Program Management Note

  • Status set to Needs Verification after move.
Generated at Thu Feb 08 04:53:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.