[SERVER-40056] Remove disabled partial implementation of streaming $group Created: 08/Mar/19  Updated: 29/Oct/23  Resolved: 11/Mar/19

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Querying
Affects Version/s: None
Fix Version/s: 4.1.9

Type: Improvement Priority: Major - P3
Reporter: David Storch Assignee: David Storch
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-4507 aggregation: optimize $group to take... Backlog
Backwards Compatibility: Fully Compatible
Sprint: Query 2019-03-25
Participants:

 Description   

We have code leftover in the code base from a partial implementation of SERVER-4507 that was never completed. (The optimization described by SERVER-4507 would improve $group on a sorted input sequence to avoid constructing a hash table.) The streaming $group code is disabled and largely untested, so it has caused confusion and may develop bugs over time. This task for this ticket is to delete any dead code related to streaming $group. This code can be reintroduced in the future if SERVER-4507 is scheduled for work.



 Comments   
Comment by Githook User [ 11/Mar/19 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@10gen.com', 'username': 'dstorch'}

Message: SERVER-40056 Remove partial implementation of streaming $group.

The streaming $group optimization was never fully implemented,
so the code was disabled. This patch removes the dead code, including
DocumentSource::getOutputSorts().
Branch: master
https://github.com/mongodb/mongo/commit/c0492bf5b77542cbacd73bcfe1e0c999b8078c07

Generated at Thu Feb 08 04:53:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.