[SERVER-40116] Unify the order of cleanup operations in dropCollection Created: 13/Mar/19  Updated: 29/Oct/23  Resolved: 14/Mar/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.10

Type: Bug Priority: Major - P3
Reporter: Xiangyu Yao (Inactive) Assignee: Xiangyu Yao (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-39514 Remove the KVDatabaseCatalogEntryBase... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Storage NYC 2019-03-25
Participants:

 Description   

Since we have the implementations of two types of replicated two-phase drops and unreplicated drop, dropCollection has different orders of cleanup operations depending on when we call UUIDCatalog::onDropCollection (by calling OpObserver::onDropCollection with CollectionDropType::kOnePhase ) and when we call _finishDropCollection.

This ticket is to unify all three implementations to always call _finishDropCollection before UUIDCatalog::onDropCollection.



 Comments   
Comment by Githook User [ 18/Mar/19 ]

Author:

{'email': 'xiangyu.yao@mongodb.com', 'name': 'Xiangyu Yao', 'username': 'xy24'}

Message: SERVER-40116 Unify the order of cleanup operations in dropCollection
Branch: master
https://github.com/mongodb/mongo/commit/6bdbf900a4f168d487858114d4bde519ba0d5fd2

Comment by Githook User [ 18/Mar/19 ]

Author:

{'email': 'xiangyu.yao@mongodb.com', 'name': 'Xiangyu Yao', 'username': 'xy24'}

Message: Revert "SERVER-40116 Unify the order of cleanup operations in dropCollection"

This reverts commit 64a5b349a56cee68c46d07ff4374cbb8e0bbed6f.
Branch: master
https://github.com/mongodb/mongo/commit/148c11dcc1c5e0bda60b5aef3df8a3f81a1681c6

Comment by Githook User [ 14/Mar/19 ]

Author:

{'name': 'Xiangyu Yao', 'username': 'xy24', 'email': 'xiangyu.yao@mongodb.com'}

Message: SERVER-40116 Unify the order of cleanup operations in dropCollection
Branch: master
https://github.com/mongodb/mongo/commit/64a5b349a56cee68c46d07ff4374cbb8e0bbed6f

Generated at Thu Feb 08 04:54:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.