[SERVER-40219] Set TransactionRouter::_initiatedCommit to true in TransactionRouter::commitTransaction Created: 19/Mar/19  Updated: 27/Oct/23  Resolved: 22/Mar/19

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: [DO NOT USE] Backlog - Sharding Team
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-40220 Remove "config server is coordinator"... Closed
Assigned Teams:
Sharding
Participants:

 Description   

This is just code cleanup blocked on removing the "config server is coordinator" override, but would be easy and quick.

Rather than setting _initiatedCommit to true in each of

  • TransactionRouter::_commitSingleShardTransaction
  • TransactionRouter::_commitReadOnlyTransaction
  • TransactionRouter::_commitMultiShardTransaction
  • TransactionRouter::_commitWithRecoveryToken

it can just be set to true in TransactionRouter::commitTransaction. This is blocked on removing the "config server is coordinator" override, because the override checks _initiatedCommit inside TransactionRouter::_commitMultiShardTransaction and expects it to be false the first time commit is called.


Generated at Thu Feb 08 04:54:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.