[SERVER-40249] Select better variable names for migration insert/update observations. Created: 20/Mar/19  Updated: 29/Mar/19  Resolved: 29/Mar/19

Status: Closed
Project: Core Server
Component/s: Replication, Sharding
Affects Version/s: 4.1.9
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Blake Oler Assignee: Blake Oler
Resolution: Won't Fix Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-40248 OplogEntry's getOperationToApply() re... Closed
Operating System: ALL
Sprint: Sharding 2019-04-08
Participants:

 Description   

Original Description

Due to an assumption ascertained from Replication code with a bug (see SERVER-40248), we select from the incorrect field when applying update operations from a multi-statement transaction. We should be applying from the o field, not the o2 field.

We should also make sure that current testing is up-to-par for this opObserver – basic testing should have caught this bug.

Investigation Update

It turns out that this bug actually isn't a bug, but for reasons previously unknown. For inserts and updates, the migration cloner transfer mods stage assumes that we are given only the _id, and reaches into the storage subsystem to retrieve the full document. The document that we pass into the cloner on transaction commit is exactly that – the _id. So the code is correct, but variables are named incorrectly.



 Comments   
Comment by Blake Oler [ 29/Mar/19 ]

Decided that the proposed changes weren't significant enough to push this ticket through. Closing as Won't Fix.

Generated at Thu Feb 08 04:54:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.