[SERVER-40386] Audit call sites of commitTransaction_forTesting() and abortTransaction_forTesting() to make sure they do not ignore server response Created: 29/Mar/19 Updated: 29/Oct/23 Resolved: 04/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.14, 4.2.0-rc1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Pavithra Vetriselvan | Assignee: | Lingzhi Deng |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v4.2
|
||||||||||||
| Sprint: | Repl 2019-05-06, Repl 2019-06-03, Repl 2019-06-17 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
As a part of We should either assert that the abort succeeded or that the command failed with NoSuchTransaction to account for transactions implicitly aborted by the server. We should also make sure we aren't using commitTransaction() or abortTransaction() in our tests unintentionally. |
| Comments |
| Comment by Githook User [ 04/Jun/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit 603d97f23ff6836be5e325bf233524d977ea9d6d) |
| Comment by Githook User [ 04/Jun/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit f41d1675fcbfe3964f18b3fa529d4dbd84a1fc1e) |
| Comment by Githook User [ 04/Jun/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |
| Comment by Githook User [ 04/Jun/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |
| Comment by Githook User [ 02/Jun/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |