[SERVER-40769] Untrack heartbeat callbacks on heartbeat cancellation Created: 22/Apr/19  Updated: 27/Oct/23  Resolved: 23/Apr/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Siyuan Zhou Assignee: Siyuan Zhou
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Gantt Dependency
has to be done before SERVER-40633 Audit all uses of _replExecutor and c... Closed
Related
related to SERVER-40795 Always execute ThreadPoolTaskExecutor... Closed
Operating System: ALL
Sprint: Repl 2019-05-06
Participants:

 Description   

After SERVER-40633, we can no longer untrack the callbacks in cancelled callbacks themselves, because on shutdown the callback will be executed on the caller thread and we cannot acquire the mutex if the callback is cancelled.



 Comments   
Comment by Siyuan Zhou [ 23/Apr/19 ]

I did a POC for this but SERVER-40795 fixes this issue with a change of the executor contract. Closing this as Work As Designed to favor SERVER-40795.

Comment by Siyuan Zhou [ 22/Apr/19 ]

Yes. This need to be done before ben.caimano's patch onĀ SERVER-40633.

Comment by Judah Schvimer [ 22/Apr/19 ]

siyuan.zhou, is there a work dependency relationship between this and SERVER-40633?

Generated at Thu Feb 08 04:55:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.