[SERVER-40784] Change document shard key code should check commitTransaction response's writeConcern status Created: 23/Apr/19  Updated: 29/Oct/23  Resolved: 01/May/19

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.1.11

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Janna Golden
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2019-05-06
Participants:

 Description   

Currently, the client's writeConcern is passed on commitTransaction, since that is the behavior of TransactionRouter::commitTransaction.

TransactionRouter::commitTransaction stops processing responses and returns the last response on seeing a response with a writeConcern error.

However, unlike the ClusterCommitTransactionCmd, which just passes the return value of TransactionRouter::commitTransaction to the client, the change shard key code checks the response status and continues with the write batch. The code should probably also check the writeConcern status and report it in the correct format for writeConcern errors for batched writes.



 Comments   
Comment by Githook User [ 01/May/19 ]

Author:

{'email': 'golden.janna@gmail.com', 'name': 'jannaerin', 'username': 'jannaerin'}

Message: SERVER-40784 Change document shard key code should check commitTransaction writeConcern status
Branch: master
https://github.com/mongodb/mongo/commit/f2bef7a49e97bdc85ebca76126c767698427731f

Generated at Thu Feb 08 04:55:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.