[SERVER-40809] fix circular dependency between db/repl/oplog and db/transaction Created: 24/Apr/19 Updated: 29/Oct/23 Resolved: 25/Apr/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.11 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Sprint: | Storage NYC 2019-05-06 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||
| Description |
|
There's a circular dependency between the db/repl/oplog and db/transaction libraries that's currently addressed by the getNextOpTimes shim in db/repl/oplog_shim. This circular dependency can be addressed by moving the oplog time reservation logic into its own library. |
| Comments |
| Comment by Githook User [ 25/Apr/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Githook User [ 25/Apr/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 25/Apr/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Githook User [ 25/Apr/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: remove persist argument from _getNextOpTimes() |
| Comment by Githook User [ 25/Apr/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: The last reference to this function was removed in commit da63637defad5975040f8eac0e98c86c8d8e2533. |
| Comment by Githook User [ 24/Apr/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: Revert " This reverts commit dd01e3b6f14f52205ccb9ff738d712531665355b. |
| Comment by Githook User [ 24/Apr/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: remove persist argument from _getNextOpTimes() |
| Comment by Benety Goh [ 24/Apr/19 ] |
|
Some overlap in scope with |