[SERVER-40836] Upgrade PCRE to 8.43 Created: 25/Apr/19  Updated: 22/May/19  Resolved: 22/May/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Spencer Jackson Assignee: Mathew Robinson (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: Dev Tools 2019-06-03
Participants:

 Comments   
Comment by Mathew Robinson (Inactive) [ 22/May/19 ]

PCRE 8.43 is a bug fix for adding some new prefix options to the C++ wrapper of the library. Unfortunately it introduced a new bug that breaks our tests so for now I'm going to close this as Won't Fix and I've opened a bug report with PCRE with a patch so this can be fixed upstream: https://bugs.exim.org/show_bug.cgi?id=2400

If you read the comment here you'll see that the prefix options were incorrectly parsed using the C++ wrapper for some UTF prefixes. The fix for this was to create an array of all of the prefix options here. But this list currently does not contain all of the valid prefix options, specifically it's missing the (*LF) option.

This breaks our RegexAcceptsLFOption test:

[main] RegexMatchExpression                     | tests:   27 | fails:    1 | assert calls:          0 | time secs:  0.001
[cpp_unit_test:expression_test] 2019-05-21T22:27:33.156+0000 	RegexAcceptsLFOption	DBException: Location51091: Regular expression is invalid: (*VERB) not recognized or malformed in test RegexAcceptsLFOption

Generated at Thu Feb 08 04:56:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.