[SERVER-40897] Default index catalog metadata to use single-phase index build format Created: 29/Apr/19 Updated: 29/Oct/23 Resolved: 17/May/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.12 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Louis Williams | Assignee: | Louis Williams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Storage NYC 2019-05-20 |
| Participants: |
| Description |
|
The default index-build protocol in the index catalog is kTwoPhase. This isn't a bug, but rather code cleanup needed for the 4.2 release. |
| Comments |
| Comment by Githook User [ 17/May/19 ] |
|
Author: {'email': 'louis.williams@mongodb.com', 'name': 'Louis Williams', 'username': 'louiswilliams'}Message: |
| Comment by Louis Williams [ 01/May/19 ] |
|
dianna.hohensee there is no user impact. I think it's confusing from a code perspective because it sets the "runTwoPhaseBuild" field in the collection catalog entry to true, despite there being no two-phase build running. |
| Comment by Dianna Hohensee (Inactive) [ 30/Apr/19 ] |
|
It does seem like an accident that we didn't make the setting toggle-able there. But does it cause any problems, or is any confusing information exposed? It looks like all it does is set a field during the index build: https://github.com/mongodb/mongo/commit/f4656acfee11569a796e06d14e4825ab54d39ecc#diff-b6438e786259a7d990bef5543a4aebbfR108. I'd rather leave it alone (so we don't have to redo it) unless it has user impact. |