[SERVER-41053] Update pipelines should not create a service context Created: 08/May/19 Updated: 29/Oct/23 Resolved: 09/May/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.12 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ian Boros | Assignee: | Ian Boros |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Query 2019-05-20 |
| Participants: |
| Description |
|
By calling DocumentSourceMock::create() from the update pipeline executor, an ExpressionContextForTest is created, which creates a full service context. This code should use a different constructor for DocumentSourceMock. |
| Comments |
| Comment by Githook User [ 09/May/19 ] | ||||||||||||||||
|
Author: {'name': 'Ian Boros', 'username': 'puppyofkosh', 'email': 'puppyofkosh@gmail.com'}Message: This commit also renames DocumentSourceMock::create to DocumentSourceMock::createForTest. | ||||||||||||||||
| Comment by Githook User [ 09/May/19 ] | ||||||||||||||||
|
Author: {'email': 'puppyofkosh@gmail.com', 'name': 'Ian Boros', 'username': 'puppyofkosh'}Message: | ||||||||||||||||
| Comment by Ian Boros [ 08/May/19 ] | ||||||||||||||||
|
I think this is all we need to fix the issue:
| ||||||||||||||||
| Comment by Ian Boros [ 08/May/19 ] | ||||||||||||||||
|
As part of this, we should consider renaming DocumentSourceMock::create() to DocumentSourceMock::createForTest(). |