[SERVER-41075] Remove 'mongo/repl/replication_coordinator.h' from op-context inclusion path Created: 09/May/19 Updated: 29/Oct/23 Resolved: 10/May/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.14, 4.1.12, 4.0.11 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | ADAM Martin (Inactive) | Assignee: | ADAM Martin (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.0, v3.6
|
||||
| Sprint: | Dev Tools 2019-05-20 | ||||
| Participants: | |||||
| Description |
|
This leaves a chain of inclusions for which it is dangerously easy to create cycles. Further it puts an extra compilation burden on the whole server for any changes which alter replication code. This makes some changes in Split Horizon easier. |
| Comments |
| Comment by Githook User [ 07/Jun/19 ] |
|
Author: {'name': 'ADAM David Alan Martin', 'email': 'adam.martin@10gen.com', 'username': 'adamlsd'}Message: A few forward-decl headers were created also. (cherry picked from commit a472b61ae5ed22a35651298fccad61843993bc49) Conflicts: |
| Comment by Githook User [ 29/May/19 ] |
|
Author: {'email': 'adam.martin@10gen.com', 'name': 'ADAM David Alan Martin', 'username': 'adamlsd'}Message: A few forward-decl headers were created also. (cherry picked from commit a472b61ae5ed22a35651298fccad61843993bc49) |
| Comment by Githook User [ 10/May/19 ] |
|
Author: {'name': 'ADAM David Alan Martin', 'username': 'adamlsd', 'email': 'adam.martin@10gen.com'}Message: A few forward-decl headers were created also. |
| Comment by ADAM Martin (Inactive) [ 09/May/19 ] |
|
Backporting to these older branches should be done. It will make Split Horizon a bit easier. |