[SERVER-41105] Rename parallel batch writer 'mutex' and 'mode' to 'lock' throughout the code Created: 13/May/19  Updated: 29/Oct/23  Resolved: 18/Jun/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.2.0-rc2, 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-39860 Separate reporting of RSTL and PBWM l... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Storage NYC 2019-05-20, Execution Team 2019-06-03, Execution Team 2019-06-17, Execution Team 2019-07-01
Participants:

 Description   

We often refer to it as a mutex or mode, and in a couple places as a lock. Let's make it consistent.



 Comments   
Comment by Githook User [ 18/Jun/19 ]

Author:

{'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@10gen.com', 'username': 'DiannaHohensee'}

Message: SERVER-41105 Consistently refer to the PBWM lock in code and text

(cherry picked from commit 8f4b0b3817fbf48cc0025632802aec37d21946da)
Branch: v4.2
https://github.com/mongodb/mongo/commit/257f4475e13ed109ea9f6543a3ac1e465a858bbf

Comment by Githook User [ 18/Jun/19 ]

Author:

{'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@10gen.com', 'username': 'DiannaHohensee'}

Message: SERVER-41105 Consistently refer to the PBWM lock in code and text
Branch: master
https://github.com/mongodb/mongo/commit/8f4b0b3817fbf48cc0025632802aec37d21946da

Comment by Dianna Hohensee (Inactive) [ 17/Jun/19 ]

Yes, this will be backported to v4.2 ASAP. Thanks for keeping an eye on it

Comment by Bruce Lucas (Inactive) [ 17/Jun/19 ]

If I'm reading this correctly it changes the serverStatus metric locks.ParallelBatchWriter to locks.parallelBatchWriterMode? Since this metric was introduced in 4.2 by SERVER-39860, would it be possible to backport this change to 4.2 to land in GA (or -rc1?) so that we have a more stable serverStatus schema?

Comment by Andy Schwerin [ 14/May/19 ]

It's the "parallel batch writer mode lock". It synchronizes between operations that can only occur when in parallel batch writer mode and operations that can only occur outside parallel batch writer mode.

Generated at Thu Feb 08 04:56:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.