[SERVER-41180] Rename 'MergingLogic' to 'DistributedPlanLogic' to avoid confusion with $merge Created: 16/May/19  Updated: 29/Oct/23  Resolved: 27/May/19

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Internal Code
Affects Version/s: None
Fix Version/s: 4.1.12

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Arun Banala
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2019-06-03
Participants:

 Description   

During development of the $merge stage we realized that the existing concept of DocumentSource::MergingLogic now had the potential to be confused with something specific to the $merge stage or with similarly named types we're introducing, MergeStrategyDescriptor and MergeStrategy.

This ticket proposes renaming 'MergingLogic' and 'mergingLogic()' to be 'DistributedPlanLogic' and 'distributedPlanLogic()' to make the distinction more clear.



 Comments   
Comment by Githook User [ 24/May/19 ]

Author:

{'name': 'Arun Banala', 'email': 'arun.banala@mongodb.com', 'username': 'banarun'}

Message: SERVER-41180 Rename 'MergingLogic' to 'DistributedPlanLogic' to avoid confusion with $merge
Branch: master
https://github.com/mongodb/mongo/commit/7536959e9afa7e5dd0ef7bc807630630e48d5706

Comment by Githook User [ 24/May/19 ]

Author:

{'email': 'arun.banala@mongodb.com', 'name': 'Arun Banala', 'username': 'banarun'}

Message: SERVER-41180 Rename 'MergingLogic' to 'DistributedPlanLogic' to avoid confusion with $merge
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/a090adccbb88462a5d37397ba19e5b2e5f20ec98

Comment by Bernard Gorman [ 22/May/19 ]

david.storch I agree that this doesn't eliminate the potential for future confusion, but it will certainly eliminate the strongest point of confusion - within the DocumentSourceMerge class itself, where we currently have MergeStrategyDescriptor, MergeStrategy, MergeMode and MergingLogic. I also think that DistributedPlanLogic captures the intent of this struct better than MergingLogic, since the struct defines not only what we do on the merging side of the splitpoint but also on the shards side.

Comment by David Storch [ 21/May/19 ]

charlie.swanson, we definitely have a concept of a "merging pipeline" to distinguish the merging part from the shards part. I don't think we should do away with that terminology entirely, so we may just have to live with the risk of confusing the $merge feature with a merging pipeline / $mergeCursors. I'm not necessarily opposed to this particular renaming, but I don't think it necessarily eliminates the possibility for future confusion.

Generated at Thu Feb 08 04:57:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.