[SERVER-41191] remove 'prepared' field from commitTransaction oplog entry format Created: 16/May/19  Updated: 29/Oct/23  Resolved: 21/May/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.1.12

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-06-03
Participants:

 Description   

The prepared field was originally intended to be used for both prepared and unprepared transactions. This is no longer the case as large unprepared transactions spanning multiple oplog entries no longer include a commitTransaction oplog entry. We should consider removing the prepared field from the IDL for the CommitTransactionOplogObject class and update all js and c++ tests that still include the prepared field in a commitTransaction oplog entry.



 Comments   
Comment by Githook User [ 21/May/19 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-41191 remove prepared field from CommitTransactionOplogObject IDL
Branch: master
https://github.com/mongodb/mongo/commit/24a79d16b0f7f5a08520380eb1e934fbd530c966

Comment by Githook User [ 21/May/19 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-41191 oplog application assumes commitTransaction refers to a prepared transaction
Branch: master
https://github.com/mongodb/mongo/commit/cdce34b4aa89b065ed41b60f217cd52c339bc99d

Comment by Githook User [ 21/May/19 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-41191 SyncTailTest stops setting prepared field on commitTransaction
Branch: master
https://github.com/mongodb/mongo/commit/ac1a0ee0babcc676b59b261bd6747553f4852a6f

Comment by Githook User [ 21/May/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-41191 OpObserverImpl stops setting prepared field on commitTransaction oplog entry
Branch: master
https://github.com/mongodb/mongo/commit/a3638ccc4889436984eb385cb7717eecd6af83cf

Comment by Githook User [ 21/May/19 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: Revert "SERVER-41191 OpObserverImplTest stops setting prepared field on commitTransaction"

This reverts commit bd8479a285fb1f2297d1a0cd1db3e4b6e5ec9501.
Branch: master
https://github.com/mongodb/mongo/commit/495dcc59fb9a73445315737d7761d1065c54a361

Comment by Githook User [ 21/May/19 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-41191 OpObserverImplTest stops setting prepared field on commitTransaction
Branch: master
https://github.com/mongodb/mongo/commit/bd8479a285fb1f2297d1a0cd1db3e4b6e5ec9501

Generated at Thu Feb 08 04:57:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.