[SERVER-41245] Add RetryableWriteError Error Label Created: 20/May/19 Updated: 29/Oct/23 Resolved: 06/Nov/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Lingzhi Deng |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Repl 2019-10-21, Repl 2019-11-04, Repl 2019-11-18 | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
The drivers would benefit from not having to keep their own list of retryable error codes and the server being able to add these whenever it wanted. This would just be codifying the current behavior and (at least at first) shouldn't hit the "exponential error codes" problem that the "Communicate Error Labels to Drivers" project had in design. |
| Comments |
| Comment by Githook User [ 06/Nov/19 ] |
|
Author: {'name': 'Lingzhi Deng', 'username': 'ldennis', 'email': 'lingzhi.deng@mongodb.com'}Message: |
| Comment by Jeremy Mikola [ 23/Oct/19 ] |
|
lingzhi.deng: Please update the The-"failCommand"-fail-point wiki page with any changes made to the failCommand fail point. That is currently the only documentation we have for the fail point, outside of some driver spec documents, so it'd be helpful to keep it up-to-date. Also, please see my comment in mongodb/specifications#672 (CR for SPEC-1420). I wanted to confirm that errorLabels: [] will override the server adding a label based on the errorCode value. That would be something worth clarifying in the wiki documentation as well, so it's clear to any readers which field takes priority. |
| Comment by Ratika Gandhi [ 01/Aug/19 ] |
|
Check the value for Drivers and either - Closing the ticket or do the work required. |
| Comment by Judah Schvimer [ 18/Jul/19 ] |
|
We should ensure that only one of this error label and TransientTransactionError appear on any commitTransaction response at a time. Otherwise it is unclear how clients should retry on commitTransaction. |