[SERVER-41278] FSM killSession helper should not kill sessions being run by background hooks Created: 22/May/19 Updated: 29/Oct/23 Resolved: 07/Aug/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1, 4.2.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Gregory Wlodarek | Assignee: | Jack Mulrow |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v4.2
|
||||||||||||||||||||
| Sprint: | Sharding 2019-07-15, Sharding 2019-07-29, Sharding 2019-08-12 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 14 | ||||||||||||||||||||
| Description |
|
In In BF-13152, we see that the checkReplDbhashBackgroundThread was chosen to be killed by the FSM test and it caused the hook to fail, resulting in the test failure. |
| Comments |
| Comment by Kelly Lewis [ 06/Apr/20 ] | |||||||||||||||||
|
Hi jack.mulrow, with this ticket and BACKPORT-5032 complete, are you able to close BF-13481 and BF-13152? | |||||||||||||||||
| Comment by Githook User [ 06/Apr/20 ] | |||||||||||||||||
|
Author: {'name': 'Jack Mulrow', 'email': 'jack.mulrow@mongodb.com', 'username': 'jsmulrow'}Message: (cherry picked from commit 5a385bb97b9af3d2c02996bc25c121198e1d9d54) | |||||||||||||||||
| Comment by Githook User [ 07/Aug/19 ] | |||||||||||||||||
|
Author: {'name': 'Jack Mulrow', 'username': 'jsmulrow', 'email': 'jack.mulrow@mongodb.com'}Message: | |||||||||||||||||
| Comment by Max Hirschhorn [ 23/May/19 ] | |||||||||||||||||
|
Other parts of the run_check_repl_dbhash_background.js hook were intended to be compatible with the snapshot_read_kill_operations.js FSM workload and FSM workloads which use the killSession() helper function.
I don't believe there is a good way for FSM workloads to restrict the logical sessions they should be able to kill. (The only basic check they do is to avoid killing themselves.) I think it'd be easier to have the run_check_repl_dbhash_background.js hook disable implicit sessions so the logic outside of the retry-on-Interrupted error responses loop isn't impacted by concurrent FSM workloads. |