[SERVER-41419] network_error_and_txn_override.js appears to have some dead code Created: 31/May/19  Updated: 29/Oct/23  Resolved: 05/Aug/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.1.14

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Judah Schvimer
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-07-29, Repl 2019-08-12
Participants:

 Description   

This bit of code specially handling createIndexes cmd and InterruptedDueToReplStateChange is never hit because code above it checks for ErrorCodes.isNotMasterError errors, including InterruptedDueToReplStateChange.



 Comments   
Comment by Githook User [ 05/Aug/19 ]

Author:

{'name': 'Judah Schvimer', 'username': 'judahschvimer', 'email': 'judah@mongodb.com'}

Message: SERVER-41419 remove dead code in network_error_and_txn_override.js
Branch: master
https://github.com/mongodb/mongo/commit/0e277af388504ca600f5ccc64a4df0c17cf1f085

Comment by Dianna Hohensee (Inactive) [ 31/May/19 ]

I couldn't track the file history far – it looks like a new file was created recently for the code. I saw repl/DS member changes, so sending it that way to start.

Generated at Thu Feb 08 04:57:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.