[SERVER-41457] Unify the different ways the TransactionParticipant offers for aborting a transaction Created: 03/Jun/19  Updated: 29/Oct/23  Resolved: 21/Aug/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.2.1, 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-39615 Replace KillSessionsDuringPrepareDoes... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Repl 2019-07-01, Repl 2019-07-15, Repl 2019-07-29, Repl 2019-08-12, Repl 2019-08-26
Participants:

 Description   

The TransactionParticipant currently has at least 6 different code paths, which can abort a transaction, with slightly different implementation details between them:

My suspicion is that this was done because there didn't use to be a good concurrency control between checking the state of the TransactionParticipant from outside and making abort decisions. Given that currently we have the Client lock concurrency control mechanism in place, all these different abort paths can be unified into some common denominator that they all share and the rest of the checks that they do can be pulled out into the calling sites.



 Comments   
Comment by Githook User [ 30/Sep/19 ]

Author:

{'name': 'Matthew Russotto', 'username': 'mtrussotto', 'email': 'matthew.russotto@mongodb.com'}

Message: SERVER-41457 Unify the different ways the TransactionParticipant offers for aborting a transaction

(cherry picked from commit f661267bf981e3b315d7e942057ab0ac9dc90bef)
Branch: v4.2
https://github.com/mongodb/mongo/commit/28f301324e1809212f6f15ba641cea77f3c8719f

Comment by Githook User [ 21/Aug/19 ]

Author:

{'name': 'Matthew Russotto', 'email': 'matthew.russotto@10gen.com', 'username': 'mtrussotto'}

Message: SERVER-41457 Unify the different ways the TransactionParticipant offers for aborting a transaction
Branch: master
https://github.com/mongodb/mongo/commit/f661267bf981e3b315d7e942057ab0ac9dc90bef

Comment by Matthew Russotto [ 08/Aug/19 ]

Code review URL: https://mongodbcr.appspot.com/498580014/

Generated at Thu Feb 08 04:57:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.