[SERVER-41495] upgrade libfmt to fix %g formatting issue Created: 04/Jun/19  Updated: 29/Oct/23  Resolved: 02/Jul/19

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 4.3 Required
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-06-17, Dev Tools 2019-07-01, Dev Tools 2019-07-15
Participants:

 Description   

libfmt has a fix from 2019-05-12 that we might want to pull.
Might as well just update it entirely.

This patches the Grisu algorithm used to produce shortest-strings (aka printf's %g or std::ios defaultfloat)
https://github.com/fmtlib/fmt/issues/1128



 Comments   
Comment by Githook User [ 02/Jul/19 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-41495 upgrade libfmt to fix a %g issue

update and run fmt/scripts/import.sh
rewrite HostAndPort formatter to avoid now-internal fmt::writer

fix merge
Branch: master
https://github.com/mongodb/mongo/commit/ac0e818b74ecdfb02bab1ea73e4f894b634184bd

Comment by Githook User [ 28/Jun/19 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-41495 HostAndPort streaming refactor
Branch: master
https://github.com/mongodb/mongo/commit/6e43dbc29112a7d7edce91cb89ec0d396463601e

Comment by Billy Donahue [ 13/Jun/19 ]

Code Review URL: https://mongodbcr.appspot.com/433500004

Comment by Billy Donahue [ 13/Jun/19 ]

Upstream problem was fixed quickly. Unblocked.

Comment by Billy Donahue [ 12/Jun/19 ]

Unfortunately newer libfmt revisions have a broken interaction with s2geometry. So blocked until that's resolved.
https://github.com/fmtlib/fmt/issues/1197

Generated at Thu Feb 08 04:57:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.