[SERVER-41495] upgrade libfmt to fix %g formatting issue Created: 04/Jun/19 Updated: 29/Oct/23 Resolved: 02/Jul/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | 4.3 Required |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Dev Tools 2019-06-17, Dev Tools 2019-07-01, Dev Tools 2019-07-15 |
| Participants: |
| Description |
|
libfmt has a fix from 2019-05-12 that we might want to pull. This patches the Grisu algorithm used to produce shortest-strings (aka printf's %g or std::ios defaultfloat) |
| Comments |
| Comment by Githook User [ 02/Jul/19 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: update and run fmt/scripts/import.sh fix merge |
| Comment by Githook User [ 28/Jun/19 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 13/Jun/19 ] |
|
Code Review URL: https://mongodbcr.appspot.com/433500004 |
| Comment by Billy Donahue [ 13/Jun/19 ] |
|
Upstream problem was fixed quickly. Unblocked. |
| Comment by Billy Donahue [ 12/Jun/19 ] |
|
Unfortunately newer libfmt revisions have a broken interaction with s2geometry. So blocked until that's resolved. |