[SERVER-41542] Use specialized appendNoName method to append unnamed fields to BSON Created: 05/Jun/19 Updated: 12/Jun/19 Resolved: 12/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Geert Bosch | Assignee: | Geert Bosch |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Execution Team 2019-06-17 |
| Participants: |
| Description |
|
This is done as part of BSON key generation (with empty field names), which is on a hot code path. This results in a surprising 10% speedup of validate. |
| Comments |
| Comment by Geert Bosch [ 12/Jun/19 ] |
|
Something must have gone wrong in my initial measurements. I can only reproduce at most 1% improvement, which is not sufficient to warrant this change. For master we'll be switching to encoding KeyString directly which is a far larger benefit, so closing this ticket as won't fix. |