[SERVER-41571] jsontests.cpp is hard to read and maintain Created: 06/Jun/19 Updated: 29/Oct/23 Resolved: 12/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | 4.3 Desired |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Dev Tools 2019-06-17 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
jsontests.cpp uses inheritance to parse each string that it wants to test. This is really wasteful and makes it difficult to see the differences among the tests in a group. The tests don't share common code. The file is about 3000 lines, and doesn't need to be. I'd like to see us make some progress toward phasing out this kind of boilerplate-dominated testing. The test for |
| Comments |
| Comment by Githook User [ 13/Jun/19 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 12/Jun/19 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 07/Jun/19 ] |
|
Code review https://mongodbcr.appspot.com/469510003/ |