[SERVER-41598] Elevate a mock storage engine implementation out of a particular unit test to make it generically usable Created: 10/Jun/19 Updated: 06/Dec/22 Resolved: 08/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Backlog - Storage Execution Team |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution
|
||||||||
| Participants: | |||||||||
| Description |
|
catalog_control_test.cpp and kv_drop_pending_ident_reaper_test.cpp both create mock storage engines. It would be useful to move and merge those implementations into a mock storage engine file, so that other tests can utilize the same implementation rather than continuing to write mocks per file. We should also explore why mocks were created instead of using the devnull storage engine. From a cursory examination, it seems arguable that the dev null engine is helpful for perf. A mock that does special actions, like one of the mocks does, would not be good for perf testing. Perhaps update the devnull engine to specify it is only used for perf reasons now? If that is true. |
| Comments |
| Comment by Benety Goh [ 19/Feb/20 ] |
|
This was partially done during https://github.com/mongodb/mongo/commit/b77010cab2386a58e05b6ffaa04921c43578467c |