[SERVER-41622] Reduce noisiness in flow_control_replica_set.js Created: 10/Jun/19  Updated: 29/Oct/23  Resolved: 16/Sep/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.1, 4.3.1

Type: Task Priority: Major - P3
Reporter: Maria van Keulen Assignee: Maria van Keulen
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-57273 remove the flow_control_replica_set.j... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Execution Team 2019-09-23
Participants:
Linked BF Score: 18

 Description   

The flow_control_replica_set.js test is intended to ensure that, when Flow Control assigns a certain number of tickets in a period of one second, an inserts-based workload executes approximately that number of inserts per second. However, the test is expected to be noisy in its current state, and can fail on a slow machine.
To reduce false positive failures of the test, we should attempt to make it less subject to noise.

One potential solution for this is to perform two calibration runs of the inserts workload. The first calibration run (already present in this test) determines an average rate of inserts without flow control. The second calibration run (to be added in this ticket) runs the same workload where flow control assigns a number of tickets that is equal to the ceiling of the calculated average of the first calibration run. If the rates of writes in both calibration runs are approximately equivalent, the test can proceed. Otherwise, the test run is deemed to be too noisy and it should return early.

Another solution is to move this test into the serial_run suite, which only runs tests serially and therefore reduces the likelihood for noise. Given the comparative ease of this solution, we will pursue it.



 Comments   
Comment by Githook User [ 09/Oct/19 ]

Author:

{'username': 'mvankeulen94', 'email': 'maria.vankeulen@mongodb.com', 'name': 'Maria van Keulen'}

Message: SERVER-41622 Reduce noise in flow_control_replica_set.js

(cherry picked from commit bcf90959f986b66689fe0b21a03572178eb2de15)
Branch: v4.2
https://github.com/mongodb/mongo/commit/de724d3d8a82667ac9da97c39abf0b9d9728cba4

Comment by Githook User [ 16/Sep/19 ]

Author:

{'name': 'Maria van Keulen', 'username': 'mvankeulen94', 'email': 'maria.vankeulen@mongodb.com'}

Message: SERVER-41622 Reduce noise in flow_control_replica_set.js
Branch: master
https://github.com/mongodb/mongo/commit/bcf90959f986b66689fe0b21a03572178eb2de15

Comment by Eric Milkie [ 14/Jun/19 ]

The potential solution outlined in the description may not be exactly how we want to fix this, but we do need to consider doing something.

Generated at Thu Feb 08 04:58:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.