[SERVER-41648] insulate third_party/ (e.g. s2geometry) from mongo/ headers Created: 12/Jun/19 Updated: 29/Oct/23 Resolved: 10/Sep/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Dev Tools 2019-06-17, Dev Tools 2019-07-01, Dev Tools 2019-07-15, Dev Tools 2019-07-29, Dev Tools 2019-08-12, Dev Tools 2019-09-09, Dev Tools 2019-09-23 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
When a third_party library includes mongo/ headers, it constrains our ability to improve those headers for use in our main codebase. While investigating So s2geometry fails to build due to an unrelated libfmt upgrade. |
| Comments |
| Comment by Githook User [ 08/Sep/19 ] |
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: This reverts commit 25720e4d716e01ae849c29ee2bbd00b8d5e82f91. fix sense of VLOG macro enable |
| Comment by Githook User [ 04/Sep/19 ] |
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: Revert " This reverts commit e58bc0f552112f5c1c16f8092b771f7e562316fb. |
| Comment by Githook User [ 04/Sep/19 ] |
|
Author: {'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue'}Message: |
| Comment by Billy Donahue [ 14/Jun/19 ] |
|
code review url: https://mongodbcr.appspot.com/475920001/ |