[SERVER-41650] loadLastOpTimeAndWallTime should use IDL to parse oplog entries Created: 12/Jun/19  Updated: 29/Oct/23  Resolved: 13/Sep/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Major - P3
Reporter: Judah Schvimer Assignee: Xuerui Fa
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
is caused by SERVER-40080 Add lastApplied and lastDurable wall ... Closed
Related
related to SERVER-40683 Make wall clock times in replication ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Repl 2019-08-12, Repl 2019-08-26, Repl 2019-09-09, Repl 2019-09-23
Participants:

 Description   

As of SERVER-40080 here the "wall" field of oplog entries no longer became optional like it is in the IDL. If we used the IDL for parsing the oplog entry there, then this backwards breaking change wouldn't have happened since the IDL considers it optional. This actually should be safe since we've been adding 'wall' since 3.6 and it's about time we made it mandatory, but we should do that in the IDL, not in one particular place where we parse the oplog entry individually.

Specifically, we should use the OplogEntry class to parse oplog entries everywhere.



 Comments   
Comment by Githook User [ 13/Sep/19 ]

Author:

{'name': 'Xuerui Fa', 'username': 'XueruiFa', 'email': 'xuerui.fa@mongodb.com'}

Message: SERVER-41650 Use IDL to parse OpTime and wall fields
Branch: master
https://github.com/mongodb/mongo/commit/865462dbae6bc73becdb3be90e13cfc0ad3021c7

Comment by Judah Schvimer [ 08/Aug/19 ]

While this is no longer necessary since we're not backporting SERVER-40080 to 3.6, it's still good code hygiene and quite small.

Generated at Thu Feb 08 04:58:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.