[SERVER-41879] cpplint.py rejects "asm volatile" Created: 24/Jun/19 Updated: 27/Oct/23 Resolved: 01/Nov/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Tools |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Gone away | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Server Development Platform
|
| Operating System: | ALL |
| Participants: |
| Description |
|
cpplint.py wants to prohibit "volatile" variable types but allow the volatile keyword on a line of inline assembly. However, it only allows __asm__ volatile, it rejects asm volatile. Let's update the check in CheckForMongoVolatile() in cpplint.py. Now, it bans volatile unless it sees __asm__ specifically. Instead, it should ban volatile unless the line matches the _MATCH_ASM regex. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 01/Nov/19 ] |
|
We removed cpplint.py, so there is no work here to do. |