[SERVER-41883] UnConditional step down should not set a maxLockTimeout while unstashing the lock resources as a part of yieldLocksForPreparedTransactions(). Created: 24/Jun/19 Updated: 29/Oct/23 Resolved: 15/Jul/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Suganthi Mani | Assignee: | Suganthi Mani |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v4.2
|
||||||||||||
| Sprint: | Repl 2019-07-01, Repl 2019-07-15, Repl 2019-07-29 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Currently, as part of yieldLocksForPreparedTransactions()], step down unstashes the prepared transaction's lock resources from transactionParticipant to its opCtx with maxLockTimeout set to non-zero value (by default it is 5ms). This means we reacquire the ticket with a maxLockTimeout set. This can fail and if it its an unconditional step down (step down via hb/ force reconfig), it can lead to server crash.
Extra Notes: Below is the scenario where we can run out of tickets. |
| Comments |
| Comment by Githook User [ 25/Jul/19 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: (cherry picked from commit 2ff54098b19ebc2b4bbf5516de6e6befb46f9fe7) |
| Comment by Githook User [ 25/Jul/19 ] |
|
Author: {'name': 'Suganthi Mani', 'username': 'smani87', 'email': 'suganthi.mani@mongodb.com'}Message: |
| Comment by Suganthi Mani [ 24/Jul/19 ] |
|
Author: {'name': 'Ian Boros', 'email': 'puppyofkosh@gmail.com', 'username': 'puppyofkosh'}Message: Revert " This reverts commit e707fd09ef0dadbb33510249732fd38c654da914. |
| Comment by Suganthi Mani [ 24/Jul/19 ] |
|
Author: {'name': 'Ian Boros', 'email': 'puppyofkosh@gmail.com', 'username': 'puppyofkosh'}Message: Revert " This reverts commit b7cec5064fb03f1e1f9bd39af35e495facfdcdc9. |
| Comment by Githook User [ 15/Jul/19 ] |
|
Author: {'name': 'Suganthi Mani', 'username': 'smani87', 'email': 'suganthi.mani@mongodb.com'}Message: (cherry picked from commit b7cec5064fb03f1e1f9bd39af35e495facfdcdc9) |
| Comment by Githook User [ 15/Jul/19 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: |