[SERVER-41961] Move bson/inline_decls.h macros to platform/compiler.h Created: 27/Jun/19  Updated: 29/Oct/23  Resolved: 15/Aug/19

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Minor - P4
Reporter: A. Jesse Jiryu Davis Assignee: ADAM Martin (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-08-12, Dev Tools 2019-08-26
Participants:

 Description   

There are two stray macros (NOLINE_DECL and PACKED_DECL) in bson/inline_decls.h. Herd them to platform/compiler.h where the rest of their flock lives.



 Comments   
Comment by Githook User [ 15/Aug/19 ]

Author:

{'name': 'ADAM David Alan Martin', 'email': 'adam.martin@10gen.com', 'username': 'adamlsd'}

Message: SERVER-41961 Remove the `NOINLINE_DECL` and replace with `MONGO_COMPILER_NOINLINE`

Also removed the `PACKED_DECL`, since it isn't used.
Branch: master
https://github.com/mongodb/mongo/commit/7eff30764a9d2137fc761e218dc2a58b6c006539

Comment by A. Jesse Jiryu Davis [ 27/Jun/19 ]

(This ticket was filed during code review for libunwind unittesting, SERVER-33259.)

Comment by Andrew Morrow (Inactive) [ 27/Jun/19 ]

We should probably fix up their names too while we are at it to bring them in conformance with our other attribute naming styles.

Generated at Thu Feb 08 04:59:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.