[SERVER-41975] Skip ASIO::basic_socket::cancel() in session_asio.h Created: 27/Jun/19 Updated: 29/Oct/23 Resolved: 02/Jul/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Rahul Sundararaman (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Service Arch 2019-07-15 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 20 | ||||||||
| Description |
|
This branch is pessimistic when called in the context of end(). getSocket()->cancel() is an unnecessary operation right before getSocket()->shutdown() and the destruction of the underlying socket. We cannot hit the baton branch in end() because we do not pass in a baton. We should remove cancelAsyncOperations() from end(). |
| Comments |
| Comment by Githook User [ 01/Jul/19 ] |
|
Author: {'name': 'Rahul Sundararaman', 'email': 'rahul.sundararaman@10gen.com', 'username': 'rsbballguy'}Message: |