[SERVER-420] [PATCH] Allow mongo to build cleanly on debian Created: 12/Nov/09 Updated: 03/Sep/20 Resolved: 02/Dec/09 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 1.1.3 |
| Fix Version/s: | 1.1.4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Fenn Bailey | Assignee: | Eliot Horowitz (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Debian Lenny |
||
| Attachments: |
|
| Participants: |
| Description |
|
the build stuff in /debian works well for ubuntu (I gather) but fails on Debian due to incorrect detection of the xulrunner version. In short, the package names differ between ubuntu and debian which breaks the version detection when only xulrunner 1.9.0 is available. Some quick notes about this patch - It's fairly hacky, but then again, the edited file is called hacks_ubuntu.py - There have been three changes: 1) I've fixed the build deps in debian/control so that it accepts either ubuntu or debian style package name/versioning. 2) I've changed the evaluation loop for 'best' in hacks_ubuntu.py to look for the highest versioned number, rather than preferencing an exact match of 'xulrunner' and then traversing to the last (which I thought a bit odd) 3) I've added a secondary xulrunner version detection, which I don't particularly like, but for the life of me I can't work out a better/cleaner way to detect the installed version on an ubuntu/debian box without doing messy stuff like parsing dpkg status files/etc. Please feel free to use all/part/none of this. Caveat: I have tested building this on a debian lenny machine and it builds cleanly. I do not have an ubuntu machine to test against, so perhaps someone else can do that bit. Ta, Fenn. |
| Comments |
| Comment by Eliot Horowitz (Inactive) [ 03/Dec/09 ] |
|
Ok - I see. |
| Comment by Fenn Bailey [ 03/Dec/09 ] |
|
Hey Eliot, Looks like you're working on a slightly different area to me (though those changes look good) - or I'm just getting confused. The changes you've put in look OK for debian etch builds (though it was mostly just docs, yeah?) The bits I changed were mostly around ./debian/* which is the package building rules/dependencies for ubuntu/debian and I can't see any of those changes in your latest group of commits. These are all for package building with: "dpkg-buildpackage -rfakeroot" rather than just a vanilla "scons all" The changes I made should allow it to build OK on etch too, though I'm not sure about the dependencies in debian/control (I don't have an etch machine handy). I guess my question is, should I be seeing the changes in my patch reflected in git master? (as I'm not yet/at the moment). Cheers! |
| Comment by Eliot Horowitz (Inactive) [ 02/Dec/09 ] |
|
i made some different changes to make it compile on debian etch |