[SERVER-42042] Warn or fail early on dynamic builds with toolchain compiler and tcmalloc Created: 02/Jul/19 Updated: 29/Oct/23 Resolved: 24/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1, 4.0.20, 4.2.9, 3.6.20 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v4.2, v4.0, v3.6
|
||||||||||||||||||||
| Sprint: | Dev Tools 2019-07-29, Dev Tools 2019-08-12, Dev Tools 2019-09-23, Dev Tools 2019-10-07, Dev Platform 2019-11-04 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
It's tempting for MongoDB developers to use --link-model=dynamic to skip the slow link step when building the server. However, it's natural to also use tcmalloc (the default), the mongodbtoolchain compiler, and --dbg=on. This leads the server to crash with "memory allocation/deallocation mismatch", which is difficult to diagnose ( To save developers from a frustrating investigation, SCons should fail if it detects this combination of flags. Perhaps the rule is enforced within files like mongodbtoolchain_v3_gcc.vars and its family. |
| Comments |
| Comment by Githook User [ 14/Jul/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}Message: (cherry picked from commit 25e8528e420bd128cd0f944aba37afce3907276e) |
| Comment by Githook User [ 14/Jul/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}Message: (cherry picked from commit 25e8528e420bd128cd0f944aba37afce3907276e) |
| Comment by Githook User [ 14/Jul/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}Message: (cherry picked from commit 25e8528e420bd128cd0f944aba37afce3907276e) |
| Comment by Githook User [ 24/Oct/19 ] |
|
Author: {'email': 'andrew.morrow@10gen.com', 'name': 'Andrew Morrow'}Message: |
| Comment by Eric Milkie [ 02/Jul/19 ] |
|
Perhaps instead of warning/failing early, we can warn late, but with a more targeted message. All we need to do is change the error message text in src/third_party/gperftools-2.7/dist/src/debugallocation.cc and direct people to consider the trilemma ticket ( |