[SERVER-42165] Replace standalone uses of stdx::mutex with mongo::mutex Created: 11/Jul/19  Updated: 29/Oct/23  Resolved: 18/Sep/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1, 4.2.2

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-41357 Add mongo::mutex polyfill Closed
is depended on by SERVER-41408 Replace remaining uses of stdx::mutex... Closed
Documented
is documented by DOCS-13423 Investigate changes in SERVER-42165: ... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Service Arch 2019-08-12, Service Arch 2019-08-26, Service Arch 2019-09-09, Service Arch 2019-09-23
Participants:
Linked BF Score: 50

 Description   

We can't yet replace uses of stdx::mutex where it is used with stdx::condition_variable (or similar external interfaces). However, we can go through and replace all uses where it is used for simple unique_lock/lock_guard.



 Comments   
Comment by Githook User [ 01/Nov/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-42165 Replace uses of stdx::mutex with mongo::Mutex
Branch: v4.2
https://github.com/mongodb/mongo/commit/bf5bef47a8e6937b4e0d2c9df3fde3470bdc72c9

Comment by Githook User [ 01/Nov/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-42165 Replace uses of stdx::mutex with mongo::Mutex
Branch: v4.2
https://github.com/10gen/mongo-enterprise-modules/commit/eb739241b4931a99de24daf9d724e71df8cb02fc

Comment by Githook User [ 31/Oct/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-41357 SERVER-41360 SERVER-43324 Add Mutex, BasicLockableAdaptor, and DiagnosticInfo

This commit backports Mutex, BasicLockableAdaptor, and DiagnosticInfo to
v4.2. These pieces came in completely in various interleaved commits.
The constituent commits partially included in this backport are listed
below. The majority of these commits are part of the "Improved
Diagnostics for Latches" epic.

Mutex:

BasicLockableAdaptor:

DiagnosticInfo:

Note that while this commit adds these pieces and integrates them into
the mongo-server codebase, it does not convert existing stdx::mutex
construction. It also does not include the updates to Interruptible that
were done as part of "Improved Diagnostics for Latches".
Branch: v4.2
https://github.com/mongodb/mongo/commit/3a05e4ce75cd03b09b52ec5943e1801c6d91279b

Comment by Githook User [ 17/Sep/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-42165 Replace uses of stdx::mutex with mongo::Mutex
Branch: master
https://github.com/mongodb/mongo/commit/bc11369435ca51e2ff6897433d00f6b909f6a25f

Comment by Githook User [ 17/Sep/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-42165 Replace uses of stdx::mutex with mongo::mutex
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/39f3e13b8bda0c898196fd361e36ff1f3a81770c

Generated at Thu Feb 08 04:59:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.