[SERVER-42166] Replace uses of stdx::condition_variable with mongo::condition_variable Created: 11/Jul/19 Updated: 06/Dec/22 Resolved: 17/Sep/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Backlog - Service Architecture |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Assigned Teams: |
Service Arch
|
||||||||||||||||
| Sprint: | Service Arch 2019-08-12, Service Arch 2019-08-26, Service Arch 2019-09-09, Service Arch 2019-09-23 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
This should be a pretty straight forward sed replace in most places. There are a few places where we use condition_variable_any or the like that may require more thought. |
| Comments |
| Comment by Benjamin Caimano (Inactive) [ 17/Sep/19 ] |
|
Turns out it's easier to instrument what we needed to entirely within waitForConditionOrInterrupt(). |
| Comment by Benjamin Caimano (Inactive) [ 04/Sep/19 ] |
|
On a somewhat positive note, the performance impact on trivial perf tests seems negligible. |
| Comment by Benjamin Caimano (Inactive) [ 04/Sep/19 ] |
|
I've discovered some philosophical problems with mongo::ConditionVariable. I can't pursue this until I fix them. I'm handling that in |