[SERVER-42279] Replace KeyString::Builder with KeyString::Value where possible Created: 18/Jul/19  Updated: 06/Dec/22  Resolved: 08/Jun/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Louis Williams Assignee: Backlog - Storage Execution Team
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Sprint: Execution Team 2019-08-12
Participants:

 Description   

Since SERVER-41717, KeyString is now called KeyString::Builder. Since we're trying to separate these two concepts, we should replace all function parameters that accept Builder with Value where possible.

In order to maintain the ability to build KeyStrings on the stack, it may be necessary to create a function that provides a view of a KeyString without copying or allocating on the heap.



 Comments   
Comment by Louis Williams [ 08/Jun/20 ]

Closing since we don't see this affecting performance. With the addition of the Pooled buffer allocation, this is less of an issue. We can file another ticket if we find that this helps.

Comment by Louis Williams [ 22/Aug/19 ]

Taking out of the epic since there has not been any visible performance impact elsewhere in the code. I also think that the only case left to change is in the validate code path, mostly covered by SERVER-42974.

Generated at Thu Feb 08 05:00:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.